Update: pageSize now defaults to moqui configuration instead of User Preference#29
Open
puru-khedre wants to merge 1 commit intomainfrom
Open
Update: pageSize now defaults to moqui configuration instead of User Preference#29puru-khedre wants to merge 1 commit intomainfrom
puru-khedre wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Passing
pageSizein an API request or changing the view size on app screens was being saved as a user preference (screen.user.page.size). This caused unintended side effects — other screens or endpoints would fallback to this saved value even whenpageSizewasn’t explicitly provided. This leads to confusing behavior, as users may not realize they’ve altered their default.What’s Changed
pageSizefrom user preferences.webapp_screen_page_size, used as the fallback when nopageSizeis provided.