Skip to content

Fix bottom sheet showing scroll position of triggering page #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noah44846 wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −0
Open

Fix bottom sheet showing scroll position of triggering page #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ...on-fragments/src/main/java/dev/hotwire/navigation/fragments/HotwireWebFragmentDelegate.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import androidx.activity.result.ActivityResultLauncher
import androidx.activity.result.contract.ActivityResultContracts.RequestMultiplePermissions
import androidx.activity.result.contract.ActivityResultContracts.RequestPermission
import androidx.activity.result.contract.ActivityResultContracts.StartActivityForResult
import androidx.core.view.ScrollingView
import androidx.lifecycle.Lifecycle.State.STARTED
import androidx.lifecycle.findViewTreeLifecycleOwner
import androidx.lifecycle.lifecycleScope
Expand Down Expand Up @@ -231,6 +232,7 @@ internal class HotwireWebFragmentDelegate(

override fun visitRendered() {
callback.onVisitRendered(location)
resetWebViewScrollForScrollingContainer()
navDestination.fragmentViewModel.setTitle(title())
removeTransitionalViews()
}
Expand Down Expand Up @@ -474,6 +476,19 @@ internal class HotwireWebFragmentDelegate(
hotwireView?.webViewRefresh?.isEnabled = enabled
}

/**
* When the WebView moves into a ScrollingView container (e.g., bottom
* sheet), its native scroll state carries over from the previous page
* and gets applied to the ScrollingView. Normally Turbo's JS would
* scroll to the top, but this has no effect on a WRAP_CONTENT WebView
* inside a ScrollingView. Reset it natively instead.
*/
private fun resetWebViewScrollForScrollingContainer() {
if (webView.parent is ScrollingView) {
webView.scrollTo(0, 0)
}
}

private fun removeTransitionalViews() {
hotwireView?.webViewRefresh?.isRefreshing = false
hotwireView?.errorRefresh?.isRefreshing = false
Expand Down