Fix CI for expanded output format support#10
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands output-format support so that HDF5 (.h5) and CSV inputs can generate ESSI and OpenSees-style outputs (in addition to the existing “point” output), and updates tests/docs to match.
Changes:
- Allow explicit
--output-formatoverrides for all input kinds (DRM/HDF5/CSV/template). - Fix ESSI output filename selection for CSV inputs (write to
.h5output rather than the source.csvname). - Update unit tests and README to validate/document the expanded behavior.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
convert.py |
Broadens supported output modes, adjusts ESSI output naming for CSV, and updates ESSI HDF5 creation logic. |
tests/test_convert_helpers.py |
Updates expectations for output-mode resolution and output filename behavior. |
tests/test_convert_fixture_data.py |
Adds fixture-driven tests for HDF5→ESSI/OpenSees and CSV→ESSI conversions. |
template/motion_setting.csv |
Normalizes CSV fixture formatting (line ending / newline consistency). |
README.md |
Documents that all output formats are supported across input kinds and clarifies metadata behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #9, which could not be updated directly because the original source branch is not accessible.
Changes included:
Validation:
Supersedes #9.