Fix ESSI output time axis and coordinate offsets#7
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes ESSI HDF5 output consistency by writing a floating-point Time axis with one entry per motion step and correcting the per-rank coordinate slice offsets when writing flattened ESSI Coordinates. It also adds regression tests to lock in the helper behavior.
Changes:
- Update ESSI
Timedataset generation tofloat64with lengthnstep(matching motion datasets). - Fix flattened ESSI
Coordinateswrite ranges by scaling node offsets by the XYZ width (3). - Add serial unit tests covering the new helper and ESSI
Timeaxis behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| convert.py | Fixes ESSI Time axis creation and corrects flattened coordinate slice offsets via get_flat_coord_range. |
| tests/test_convert_helpers.py | Adds regression tests for get_flat_coord_range and ESSI Time axis shape/dtype/values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing