Skip to content

Fix: typo #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chocorean wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: typo #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion guides/the-ultimate-guide-to-rust-newtypes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ Well, `FromStr` came first. It predates the addition of `TryFrom` to the standar
Whether you choose to implement `FromStr` in addition to `From` or `TryFrom` depends on three things:

- Whether you're interfacing with older code that has parameters bounded by `FromStr`, in which case you have no choice but to implement it for your newtype.
- Whether you want to take advantage of imnplementations over `FromStr` types, like [`str::parse`](https://doc.rust-lang.org/stable/std/primitive.str.html#method.parse) and [`serde_with::DeserializeFromStr`](https://docs.rs/serde_with/latest/serde_with/derive.DeserializeFromStr.html).
- Whether you want to take advantage of implementations over `FromStr` types, like [`str::parse`](https://doc.rust-lang.org/stable/std/primitive.str.html#method.parse) and [`serde_with::DeserializeFromStr`](https://docs.rs/serde_with/latest/serde_with/derive.DeserializeFromStr.html).
- Personal preference.

In the latter case, _be consistent_. Whatever your team decides, document it and use a linter to enforce your choice, because none of you can be trusted to remember.
Expand Down