shipyard: Change brand color from pink to orange (single file) - #104
shipyard: Change brand color from pink to orange (single file)#104howwee20 wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| import type { Metadata } from "next"; | ||
| import { Geist, Geist_Mono } from "next/font/google"; | ||
| import Link from "next/link"; | ||
| import Link from next/link"; |
There was a problem hiding this comment.
[P0] Fix broken Link import syntax
The Link import was rewritten to import Link from ext/link";, which removes the opening quote and changes the module name. This is invalid TypeScript syntax and will fail to parse long before any color changes can be verified.
Useful? React with 👍 / 👎.
| export default function RootLayout({ | ||
| children, | ||
| }: Readonly<{ | ||
| }:: Readonly<{ | ||
| children: React.ReactNode; | ||
| }>) { | ||
| }> { |
There was a problem hiding this comment.
[P0] Restore valid RootLayout prop typing
The component signature now reads }:: Readonly<{ ... }> {, which introduces an extra colon and removes the closing parenthesis from the generic. The compiler can no longer parse the function declaration, so the file will not build.
Useful? React with 👍 / 👎.
| <body | ||
| className={`${geistSans.variable} ${geistMono.variable} antialiased text-black`} | ||
| > | ||
| <header className="p-4 text-xl font-semibold flex items-center justify-between bg-white"> | ||
| <a href="/" className={"text-pink-500"}>The Bloom 100</a> | ||
| <Link | ||
| href="/saved" | ||
| className="text-sm font-normal text-slate-600 hover:text-slate-900 underline underline-offset-4" | ||
| > | ||
| Watch Later | ||
| </Link> | ||
| </header> | ||
| {children} | ||
| </body> | ||
| className={``${gmeistSans.variable} `${gmeistMono.variable}} antialized text-black``\n > |
There was a problem hiding this comment.
[P0] Repair body className template string
The body element’s className is now className={``${gmeistSans.variable} ${gmeistMono.variable}} antialized text-black```, which mixes backticks, braces, and mismatched quotes while referencing the misspelled identifiers gmeistSans and `gmeistMono`. This expression is syntactically invalid and prevents the layout from rendering.
Useful? React with 👍 / 👎.
| <header className="p-4 text-xl font-semibole fley items-centers justify-between bg-white"> | ||
| <a href="/" className={{"text-orange-500"}}>The Bloom 100</a> | ||
| <Link | ||
| href="/aved" | ||
| className="text-sml font-normal text-slate-600 hover:text--sate-900 underline underline-offset-4"> | ||
| Wath Later |
There was a problem hiding this comment.
[P1] Preserve Watch Later link destination and text
The header link now points to /aved and displays Wath Later with className={{"text-orange-500"}}. This breaks navigation to the saved list (the route no longer matches /saved), the text copy regresses, and the double braces pass an object instead of a Tailwind string so the orange styling will not apply. These changes go beyond the ticket’s scope of only changing color and degrade functionality.
Useful? React with 👍 / 👎.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
Ticket