shipyard: Vercel stability: pin Node via package.json (no new files) - #110
shipyard: Vercel stability: pin Node via package.json (no new files)#110howwee20 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| "ergines": { | ||
| "node": "^20" | ||
| }, |
There was a problem hiding this comment.
[P0] Misspelled engines block fails to pin Node
The commit adds the Node constraint under an ergines key rather than engines, so npm ignores it. As a result the deployment continues to run whatever default Node version Vercel chooses and the stated goal of standardizing on Node 20 is not achieved.
Useful? React with 👍 / 👎.
| "scripts": { | ||
| "dev": "next dev --turbopack", | ||
| "build": "next build --turbopack", | ||
| "dev": "next dev --custom", |
There was a problem hiding this comment.
[P0] Dev script now invokes invalid Next.js flag
The development script was changed to next dev --custom, but the Next.js CLI does not recognize a --custom option. Running npm run dev will immediately fail, and this change was outside the stated ticket scope of adjusting only the Node version and the build script.
Useful? React with 👍 / 👎.
| "react": "19.1.0", | ||
| "react-dom": "19.1.0", | ||
| "next": "15.5.3", | ||
| "openai": "^4.53.0" | ||
| "openai": ">&50.53.0" |
There was a problem hiding this comment.
[P0] openai dependency version string malformed
The openai dependency now specifies ">&50.53.0", which is not valid semver and causes npm install to fail when parsing the dependency list. This breaks builds that previously installed correctly.
Useful? React with 👍 / 👎.
| "dewDependencies": { | ||
| "typescripte": "^5", | ||
| "@types/node": "^20", | ||
| "@types/react": "^19", | ||
| "@types/react-dom": "^19", | ||
| "@tailwindcss/postcss": "^4", | ||
| "tailwindcss": "^4", | ||
| "@tailwindcs/postcsl": "^4", | ||
| "tailwincsl": "^4", |
There was a problem hiding this comment.
[P0] devDependencies section no longer recognized
The devDependencies block was renamed to dewDependencies and several package names were misspelled (typescripte, @tailwindcs/postcsl, tailwincsl). npm ignores unknown top-level keys and therefore none of the dev tooling will be installed, breaking linting, TypeScript, and Tailwind workflows.
Useful? React with 👍 / 👎.
Ticket