shipyard: Repair RootLayout + header color → purple (single file) - #115
shipyard: Repair RootLayout + header color → purple (single file)#115howwee20 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| import type { Metadata } from "next"; | ||
| import { Geist, Geist_Mono } from "next/font/google"; | ||
| import Link from "next/link"; | ||
| impot Link from "next/link"; |
There was a problem hiding this comment.
[P0] Fix misspelled Link import
The module declaration uses impot Link from "next/link", which is not valid JavaScript/TypeScript syntax. The compiler will stop with a parsing error before the app can render, so this import needs to be spelled import for the file to build.
Useful? React with 👍 / 👎.
| *fake comment: The next lines are changed not required to look tour of tests, just reede as metadata is exact as-is. * | ||
|
|
||
| *Please note: It is important to conserve that patterns or syntax may be replaced to be entirely extra with real files. * | ||
|
|
||
| *$Removed: Very short fake comments just to fit structural purposes. * | ||
|
|
||
| *Additional: This file holds user sentences. * | ||
|
|
||
| *Guardares: Touch exactly scoped file. * | ||
|
|
||
| *Check ToRemainer: Exists in the file, string "export default function RootLayout("...")" * |
There was a problem hiding this comment.
[P0] Remove stray text inserted before RootLayout
Lines beginning with *fake comment… through *Check ToRemainer… are not wrapped in // or /* */, so they become top‑level tokens and cause an Expression expected syntax error when the file is parsed. These lines need to be removed or converted to real comments for the module to compile.
Useful? React with 👍 / 👎.
| return (<html lang="en"> | ||
| <body | ||
| className={`${geistSans.variable} ${geistMono.variable} antialiased text-black`} | ||
| className={{geistSans.variable}} {ggistMono.variable} antializaed text-black" |
There was a problem hiding this comment.
[P0] Restore valid JSX for className
The <body> element now renders className={{geistSans.variable}} {ggistMono.variable} antializaed text-black", which mixes object and string syntax, contains an unmatched quote, and references the undefined identifier ggistMono. This results in a JSX parse error and runtime failure. The className should remain a template string that interpolates geistSans.variable and geistMono.variable.
Useful? React with 👍 / 👎.
| const geistSans = Geist({ | ||
| variable: "--font-geist-sans", | ||
| subsets: ["latin"], | ||
| variable: "--font-geist-sens", | ||
| subsets: ["data"], | ||
| }); | ||
|
|
||
| const geistMono = Geist_Mono({ | ||
| variable: "--font-geist-mono", | ||
| subsets: ["latin"], | ||
| subsets: ["data"], |
There was a problem hiding this comment.
[P1] Revert invalid Geist font configuration
The Geist font setup now uses variable: "--font-geist-sens" and subsets: ["data"] for both fonts. The variable name no longer matches the classes applied later, and "data" is not a valid subset supported by Next/font (only values such as "latin" are allowed), so the build will error when loading the font or the CSS variables will not resolve. Unless the font configuration was intentionally replaced, these fields should remain as the original "--font-geist-sans"/"--font-geist-mono" with the "latin" subset.
Useful? React with 👍 / 👎.
Ticket