Skip to content

feat: port marshaller from 2.x.x to 3.x.x#4579

Merged
GordonSmith merged 2 commits intohpcc-systems:mainfrom
GordonSmith:MARSHALLER_PORT_3
Apr 21, 2026
Merged

feat: port marshaller from 2.x.x to 3.x.x#4579
GordonSmith merged 2 commits intohpcc-systems:mainfrom
GordonSmith:MARSHALLER_PORT_3

Conversation

@GordonSmith
Copy link
Copy Markdown
Member

@GordonSmith GordonSmith commented Apr 13, 2026 •
edited
Loading

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@GordonSmith
feat: port marshaller from 2.x.x to 3.x.x
83009a4 
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith force-pushed the MARSHALLER_PORT_3 branch 4 times, most recently from b88d09a to 4e5e7b0 Compare April 20, 2026 10:26
@GordonSmith GordonSmith changed the title Marshaller port 3 feat: port marshaller from 2.x.x to 3.x.x Apr 20, 2026
@GordonSmith GordonSmith marked this pull request as ready for review April 20, 2026 10:28
@GordonSmith GordonSmith requested a review from jeclrsg April 20, 2026 10:28
@GordonSmith
Copy link
Copy Markdown
Member Author

GordonSmith commented Apr 20, 2026 •
edited
Loading

@jeclrsg - this is in two commits:

  1. The orig 2.x.x sources
  2. The changes needed to port to 3.x.x

Its only the second commit that needs review

jeclrsg
jeclrsg reviewed Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith I didn't spot any issues with any of the migrated code. Just a few questions

Comment thread packages/marshaller/src/publish.ts Outdated
Comment thread packages/phosphor/src/SplitPanel.ts
Comment thread package-lock.json
Comment thread packages/marshaller/src/__package__.ts
@GordonSmith GordonSmith requested a review from jeclrsg April 21, 2026 09:52
@GordonSmith
feat: Refactor marshaller to vite + 3.x.x
8403c27 
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith merged commit ddca2ce into hpcc-systems:main Apr 21, 2026
3 of 4 checks passed
@GordonSmith GordonSmith deleted the MARSHALLER_PORT_3 branch April 21, 2026 14:12
This was referenced Apr 21, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeclrsg jeclrsg jeclrsg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GordonSmith @jeclrsg