Allow comparators access to the complete list of entries#1894
Open
scratchyone wants to merge 1 commit intohrsh7th:mainfrom
Open
Allow comparators access to the complete list of entries#1894scratchyone wants to merge 1 commit intohrsh7th:mainfrom
scratchyone wants to merge 1 commit intohrsh7th:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small change that allows comparators to access the entire list of entries, by adding an optional comparator argument that contains the current list of completion entries. This makes it easier for slow comparators (for example, something requiring an API call, disk I/O, or ML model execution) to batch their computations, execute them all at once, and then return cached results for the rest of the comparisons.