TaskGroup type + GitHub sub-issue detection + group state - #83
Open
hsubra89 wants to merge 8 commits into
Open
Conversation
- TaskGroup enum (Standalone/Group) with next_eligible_sub_issue, is_complete, all_sub_issue_ids, parent methods - GitHub GraphQL query fetching sub-issues with GraphQL-Features header - Grouping logic: labeled sub-issues form Group, unlabeled ignored, children deduplicated from top-level standalone list - Intra-group topological sort via Kahn's algorithm in deps.rs - TaskSource trait extended with fetch_eligible_task_groups() - CurrentGroupState in StateData with set/mark/complete/get methods - Unit tests for GraphQL parsing, group state roundtrip, topo sort Closes #77 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
Review Summary3 warnings found that need code changes before merge. 10 informational items noted for optional improvement. Warnings (must fix)
Info (optional improvements)
|
- Add `state` field to GraphQL sub-issue query and GqlSubIssue struct - Filter out non-OPEN sub-issues before including them in task groups - Rename GqlLabel2 to GqlLabel for consistency - Add tests for closed sub-issue filtering Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove the .filter(|d| group_ids.contains(d)) that was discarding external dependencies, so ALL deps (intra-group and external) are checked against done_ids. Update the unit test to verify external deps properly block sub-issues until resolved. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
|
The warning about external dependency blocking is outdated — commit 8ba7586 removed the |
Owner
Author
|
The external dependency blocking warning is now resolved — commit 8ba7586 removed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #77
Automated implementation by rlph.