Conversation
Core bridge (src/core/bridge.mjs): - Add 5 missing command handlers to dispatchCommand(): validate, codex-check, pre-process, post-process, hooks - codex-check uses ValidatorRegistry for deep analysis - hooks handler: full install/uninstall/list/status lifecycle Hermes plugin (src/integrations/hermes-agent/): - tools.py: dedup helpers, delegate to __init__.py via lazy import - bridge.mjs: quality gate soft-fail -> hard-fail on exception - types.ts + plugin.yaml: version aligned to 2.2.0 120 Python tests pass. tsc clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
HIGH: Core bridge.mjs missing command handlers
dispatchCommand() listed 9 commands in KNOWN_COMMANDS but only handled 4. The 5 missing commands (validate, codex-check, pre-process, post-process, hooks) all returned Unknown command.
MEDIUM: Version drift
types.ts=2.0.0, plugin.yaml=2.1.0, init.py=v2.2 — all aligned to 2.2.0
LOW: Duplicate helpers in tools.py
Removed duplicate _call_bridge and _find_project_root, now delegates to init.py via lazy import.
LOW: Quality gate soft-fail
bridge.mjs returned passed:true when quality gate threw — now returns passed:false.
Verification