fix: implement keyword-based routing in getTaskRoutingRecommendation#35
Merged
fix: implement keyword-based routing in getTaskRoutingRecommendation#35
Conversation
Previously, getTaskRoutingRecommendation was a stub that returned empty suggestedSkill and always routed to 'enforcer'. This fix implements proper keyword-based routing that: - Matches task descriptions against routing keywords - Routes to appropriate agent/skill combinations - Returns correct confidence levels - Falls back to 'enforcer' with 'enforcer' skill when no match This enables proper task delegation based on task description content.
- Add 'types: ["node"]' to compilerOptions - Resolves TS2307 errors for Node.js built-in modules (fs, path, crypto, etc.) - Resolves TS2580 errors for Node.js globals (process, Buffer, require)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getTaskRoutingRecommendationProblem
The
getTaskRoutingRecommendationfunction insrc/enforcement/enforcer-tools.tswas a stub that returned emptysuggestedSkillregardless of task complexity. This meant tasks were not being routed to appropriate agents/skills.Additionally, the tsconfig.json was missing Node.js type declarations, causing hundreds of TS2307/TS2580 errors for built-in modules like
fs,path,crypto,process,Buffer, andrequire.Solution
Part 1: Keyword-based routing
ROUTING_MAPPINGSarrayPart 2: TypeScript configuration
"types": ["node"]to tsconfig.json compilerOptionsTest plan