[Snyk] Fix for 6 vulnerabilities

[q1blue]

Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

• plugins/catalog-backend-module-ldap/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning

Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

	Issue	Score
	Improper Handling of Unicode Encoding SNYK-JS-TAR-15038581	210
	Use of a Cryptographic Primitive with a Risky Implementation SNYK-JS-ELLIPTIC-14908844	146
	UNIX Symbolic Link (Symlink) Following SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291	113
	Prototype Pollution SNYK-JS-LODASH-15053838	88
	Prototype Pollution SNYK-JS-LODASHES-15053836	88
	Regular Expression Denial of Service (ReDoS) SNYK-JS-DIFF-14917201	62

---

Important

• Check the changes in this PR to ensure they won't cause issues with your project.
• Max score is 1000. Note that the real score may have changed since the PR was raised.
• This PR was automatically created by Snyk using the credentials of a real user.

---

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

---

Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution

---

EntelligenceAI PR Summary

Updates dependency specifications in the LDAP catalog backend module package.json, replacing workspace references with explicit versions and upgrading lodash for security.

• Pinned @backstage/backend-tasks to version 0.6.1
• Pinned @backstage/catalog-model to version 0.1.1
• Pinned @backstage/plugin-catalog-common to version 0.1.0
• Pinned @backstage/plugin-catalog-node to version 1.13.0
• Upgraded lodash dependency from ^4.17.21 to ^4.17.23

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[gemini-code-assist]

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by upgrading several key dependencies within the plugins/catalog-backend-module-ldap module. The updates target and resolve six identified vulnerabilities, ranging from medium to high severity, thereby mitigating potential risks associated with outdated or vulnerable package versions.

Highlights

• Dependency Updates: Several @backstage packages and lodash have been updated in plugins/catalog-backend-module-ldap/package.json to address known security vulnerabilities. Notably, workspace:^ dependencies were replaced with specific version numbers.
• Vulnerability Fixes: This pull request resolves 6 identified vulnerabilities, including a high-severity UNIX Symbolic Link Following issue and multiple medium-severity issues such as Prototype Pollution and Regular Expression Denial of Service (ReDoS).
• Yarn Lock Warning: The yarn.lock file was not automatically updated by Snyk, which means users relying on Yarn's zero-installs feature will need to run yarn manually to update the ./yarn/cache directory.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[snyk-io]

⛔ Snyk checks have failed. 1 issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (1)
⛔	Open Source Security	0	0	1	0	1 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	react@​17.0.2
	storybook-dark-mode@​1.1.2
	swc-loader@​0.2.3
	react-hot-loader@​4.13.1
	typescript@​4.7.4
	react-dom@​17.0.2

View full report

[socket-security]

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert  (click "▶" to expand/collapse)
Warn		License policy violation: npm polished under OFL-1.1 License: OFL-1.1 - the applicable license policy does not allow this license (4) (package/docs/assets/fonts/LICENSE.txt) From: ? → npm/@storybook/addon-actions@6.5.16 → npm/polished@4.2.2 ℹ Read more on: This package | This alert | What is a license policy violation? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev. Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/polished@4.2.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		License policy violation: npm typescript under W3C-20150513 License: W3C-20150513 - the applicable license policy does not allow this license (4) (package/ThirdPartyNoticeText.txt) License: CC-BY-4.0 - the applicable license policy does not allow this license (4) (package/ThirdPartyNoticeText.txt) License: LicenseRef-W3C-Community-Final-Specification-Agreement - the applicable license policy does not allow this license (4) (package/ThirdPartyNoticeText.txt) License: MIT-Khronos-old - the applicable license policy does not allow this license (4) (package/ThirdPartyNoticeText.txt) From: storybook/package.json → npm/typescript@4.7.4 ℹ Read more on: This package | This alert | What is a license policy violation? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev. Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/typescript@4.7.4. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

[entelligence-ai-pr-reviews]

Walkthrough

This PR updates dependency management in the LDAP catalog backend module by transitioning from workspace protocol references to explicit version numbers for several Backstage packages. The changes pin specific versions of backend-tasks (0.6.1), catalog-model (0.1.1), plugin-catalog-common (0.1.0), and plugin-catalog-node (1.13.0). Additionally, the lodash dependency is upgraded from version 4.17.21 to 4.17.23, which likely addresses known security vulnerabilities. These modifications indicate preparation for package publishing or establishing stable dependency versions rather than relying on workspace-relative references.

Changes

File(s)	Summary
plugins/catalog-backend-module-ldap/package.json	Transitioned Backstage package dependencies from workspace protocol to explicit versions (@backstage/backend-tasks: 0.6.1, @backstage/catalog-model: 0.1.1, @backstage/plugin-catalog-common: 0.1.0, @backstage/plugin-catalog-node: 1.13.0) and upgraded lodash from ^4.17.21 to ^4.17.23.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager
    participant Deps as Dependencies
    
    Note over Dev,Deps: Dependency Version Update Process
    
    Dev->>PM: Update package.json versions
    activate PM
    Note right of PM: @backstage/backend-tasks: 0.6.1<br/>@backstage/catalog-model: 0.1.1<br/>@backstage/plugin-catalog-common: 0.1.0<br/>@backstage/plugin-catalog-node: 1.13.0<br/>lodash: 4.17.23
    PM->>Deps: Resolve new versions
    Deps-->>PM: Dependencies resolved
    PM-->>Dev: Update complete
    deactivate PM
    
    Note over Dev,Deps: No architectural or interaction changes

Loading

▶️ ⚡ AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf

Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

• ⚠️ Potential Issue - May require further investigation.
• 🔒 Security Vulnerability - Fix to ensure system safety.
• 💻 Code Improvement - Suggestions to enhance code quality.
• 🔨 Refactor Suggestion - Recommendations for restructuring code.
• ℹ️ Others - General comments and information.

Interact with the Bot:

• Send a message or request using the format:
  @entelligenceai + *your message*

Example: @entelligenceai Can you suggest improvements for this code?

• Help the Bot learn by providing feedback on its responses.
  @entelligenceai + *feedback*

Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

1. config - shows the current config
2. retrigger_review - retriggers the review

More commands to be added soon.

[gemini-code-assist]

Code Review

This pull request from Snyk aims to fix several security vulnerabilities by updating dependencies. While the intention is good, the proposed changes are not suitable for this monorepo setup. The PR replaces workspace:^ dependencies with pinned versions from the npm registry, which undermines the monorepo's architecture and will likely break the local development workflow. Additionally, the yarn.lock file has not been updated, which is a critical part of any dependency change. I've left a detailed comment explaining the issue and recommending the correct approach to fix these vulnerabilities, which involves updating the transitive dependencies within the workspace packages and regenerating the lockfile. This PR should not be merged in its current state.

[gemini-code-assist]

While the intent to fix vulnerabilities is correct, the approach taken by this automated PR is not suitable for this monorepo.

Incorrect workspace: resolution:
The changes from workspace:^ to pinned versions (e.g., 0.6.1) for @backstage packages are problematic. This breaks the monorepo's local development workflow by forcing the use of published packages from the registry instead of the local source code.

Missing lockfile update:
The PR description correctly notes that yarn.lock has not been updated. Any dependency change must be accompanied by a lockfile update to ensure deterministic installs.

Recommended approach:
This PR should be closed. The vulnerabilities should be fixed manually:

1. For the @backstage packages, identify the underlying vulnerable dependencies and update them in their respective package.json files within this monorepo.
2. Update lodash to ^4.17.23 as suggested.
3. Run yarn install (or equivalent) to generate the updated yarn.lock file.
4. Submit a new PR with all the package.json changes and the updated yarn.lock file.

This will correctly resolve the vulnerabilities while preserving the integrity of the monorepo setup.