[Snyk] Security upgrade @backstage/types from 0.0.0-use.local to 0.1.1 #10700
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-14908844 - https://snyk.io/vuln/SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291 - https://snyk.io/vuln/SNYK-JS-LODASH-15053838 - https://snyk.io/vuln/SNYK-JS-LODASHES-15053836 - https://snyk.io/vuln/SNYK-JS-DIFF-14917201
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security posture by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, aims to fix several security vulnerabilities by changing the version of the @backstage/types dependency. However, the proposed change incorrectly downgrades the package from a workspace-relative version (workspace:^, which resolves to 1.1.0 in this monorepo) to a much older, hardcoded version (0.1.1). This is a critical issue as it's a major version downgrade that can introduce breaking changes and dependency conflicts. It also deviates from the monorepo's dependency strategy. The fact that Snyk failed to update the yarn.lock file further indicates that this change is problematic. I have added a comment recommending to revert this change and to instead address the security vulnerabilities within the current version of the @backstage/types package.
| "dependencies": { | ||
| "@backstage/plugin-permission-common": "workspace:^", | ||
| "@backstage/types": "workspace:^" | ||
| "@backstage/types": "0.1.1" |
There was a problem hiding this comment.
This change downgrades @backstage/types from workspace:^ (which resolves to version 1.1.0 in this monorepo) to a hardcoded version 0.1.1. This is a significant downgrade across major versions (1.x to 0.x) and is likely to introduce breaking changes and inconsistencies.
Using workspace:^ is standard practice in this monorepo to ensure all packages use the same version of internal dependencies. Removing it will cause this package to fetch an old version from the registry, potentially leading to multiple, incompatible versions of @backstage/types in the final build.
While this change is intended to fix security vulnerabilities, this downgrade is a high-risk approach. It's recommended to investigate and fix the vulnerabilities within the current @backstage/types@1.1.0 package or upgrade it if a newer, non-vulnerable version is available, rather than pinning to a very old version. This change should be reverted.
| "@backstage/types": "0.1.1" | |
| "@backstage/types": "workspace:^" |
WalkthroughThis pull request updates the dependency management for the Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant PM as Package Manager
participant WS as Workspace
participant NPM as NPM Registry
participant SC as search-common Plugin
Note over Dev,SC: Dependency Resolution Change
Dev->>PM: npm install / yarn install
alt Before Change (workspace:^)
PM->>WS: Resolve @backstage/types
WS->>PM: Return local workspace version
PM->>SC: Link local @backstage/types
else After Change (0.1.1)
PM->>NPM: Fetch @backstage/types@0.1.1
NPM->>PM: Return published package
PM->>SC: Install @backstage/types@0.1.1
end
Note over SC: Plugin now uses published<br/>version instead of workspace
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/search-common/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
SNYK-JS-ELLIPTIC-14908844
SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291
SNYK-JS-LODASH-15053838
SNYK-JS-LODASHES-15053836
SNYK-JS-DIFF-14917201
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution
EntelligenceAI PR Summary
Updated dependency specification for
@backstage/typesin search-common plugin from workspace reference to fixed version.workspace:^to0.1.1inplugins/search-common/package.json