Open
Conversation
Contributor
Author
|
Would it be interesting to use @botonic/dx to encapsulate all devDependecies and tsconfig, babel, eslint, jest configurations? |
68aef6b to
74c6811
Compare
AinaVendrell
approved these changes
Feb 21, 2024
02e6987 to
4140677
Compare
…nd remove nlp dependencies
…zer-webpack-plugin
1f60b51 to
28fdfbf
Compare
129c216 to
0b27a9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes nlp dependencies (package.json folder and scripts)
Upgrade versions of the dependencies
Update the package.json scripts: use webpack-dev-server in start script and add the deploy script.
Add jest.config.js
Context
Blank examples must not have any nlp dependencies.
Remove @babel/plugin-proposal-object-rest-spread, @babel/plugin-proposal-class-properties because both are in ECMAScript standard
Approach taken / Explain the design
To document / Usage example
Testing
The pull request...