Fixed disabled property with ngModel#95
Merged
carlosmintfan merged 2 commits intomainfrom Jan 15, 2026
Merged
Conversation
Co-authored-by: carlosmintfan <carlosmintfan@users.noreply.github.com>
9c768c6 to
1cd171e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix has been successfully applied and tested. Here's a summary:
Changes Made
File:
hugerte-angular-component/src/main/ts/editor/editor.component.ts&& this._editor.initializedcheck from the disabled setter (line 77)File:
hugerte-angular-component/src/test/ts/browser/DisabledPropertyTest.ts(new)Why This Fixes the Issue
In template-driven forms with ngModel, the
setDisabledStatemethod is called during form initialization. The previous code only set the editor mode ifthis._editor && this._editor.initializedwas true, which meant:setDisabledStatewas called before the editor was fully initialized → mode not setsetDisabledStatewas called during thesetupcallback (beforeinitializedflag is set) → mode not setBy removing the
initializedcheck, the mode is now set immediately when the editor instance is available (during thesetupcallback), which happens before the editor is fully initialized. This ensures the disabled state is applied correctly regardless of whensetDisabledStateis called.The fix also maintains the
readonly: this.disabledconfig in the initialization options as a fallback for cases where the disabled property is set very early.Closes #65
opencode session | github run