test: add regression test for no_split_module_classes accepting set type#4048
Open
UFO0506 wants to merge 1 commit into
Open
test: add regression test for no_split_module_classes accepting set type#4048UFO0506 wants to merge 1 commit into
UFO0506 wants to merge 1 commit into
Conversation
get_balanced_memory and infer_auto_device_map should accept a set for no_split_module_classes without raising 'TypeError: unhashable type: set'. Bug was present in <=1.5.0, fixed in huggingface#2345, this test prevents regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds a regression test for
get_balanced_memoryandinfer_auto_device_mapwhen
no_split_module_classesis passed as asetinstead of alistortuple.Background
In accelerate <= 1.5.0, passing a
setcaused:TypeError: unhashable type: 'set'
File "accelerate/utils/modeling.py", in get_balanced_memory
if set(no_split_children.keys()) == set(no_split_module_classes):
This was silently fixed as part of #2345, but no regression test was added.
This PR adds explicit coverage so the fix cannot regress undetected.
Testing
pytest tests/test_modeling_utils.py::ModelingUtilsTester::test_get_balanced_memory_no_split_module_classes_set -v # 1 passed