Skip to content

Add not_params to ModularPipelineTesterMixin#14207

Open
yiyixuxu wants to merge 1 commit into
mainfrom
modular-tester-not-params
Open

Add not_params to ModularPipelineTesterMixin#14207
yiyixuxu wants to merge 1 commit into
mainfrom
modular-tester-not-params

Conversation

@yiyixuxu

Copy link
Copy Markdown
Collaborator

Pipelines sometimes deliberately drop a canonical param — e.g. guidance-distilled pipelines don't accept negative_prompt. Test classes can now declare these in not_params and test_pipeline_call_signature asserts they are absent from the pipeline's inputs, so reintroducing one by accident fails the test.

Adopted in the flux2-klein test classes (negative_prompt).

What does this PR do?

Fixes # (issue)

Before submitting

  • Did you use an AI agent (Claude Code, Codex, Cursor, etc.) to help with this PR? If so:
    • Did you read the Coding with AI agents guide?
    • Did you run the self-review skill on the diff?
    • Did you share the final self-review notes in the PR description or a comment?
  • Did you read the contributor guideline?
  • Did you read our philosophy doc? (important for complex PRs)
  • Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?
  • Are you the author (or part of the team) of the model/pipeline (only applicable for model/pipeline related PRs)?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Pipelines sometimes deliberately drop a canonical param — e.g. guidance-distilled
pipelines don't accept negative_prompt. Test classes can now declare these in
not_params and test_pipeline_call_signature asserts they are absent from the
pipeline's inputs, so reintroducing one by accident fails the test.

Adopted in the flux2-klein test classes (negative_prompt).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions github-actions Bot added the tests label Jul 16, 2026
@yiyixuxu
yiyixuxu requested a review from sayakpaul July 16, 2026 20:05
@github-actions github-actions Bot added the size/S PR with diff < 50 LOC label Jul 16, 2026
@yiyixuxu

Copy link
Copy Markdown
Collaborator Author

for #14177 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S PR with diff < 50 LOC tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants