This repository was archived by the owner on Jan 27, 2026. It is now read-only.
fix(windows): force USE_CUDA/USE_ROCM definitions to ensure PyTorch guards are not bypassed#303
Merged
mfuntowicz merged 17 commits intomainfrom Nov 24, 2025
Merged
Conversation
158bffe to
775300c
Compare
…compile_definition in windows.cmake
3b6264e to
fcd838a
Compare
MekkCyber
reviewed
Nov 19, 2025
Contributor
MekkCyber
left a comment
There was a problem hiding this comment.
Thanks a lot ! Could you update the PR description because it mentions _WIN32 not being set, but this is related to USE_CUDA and USE_ROCM please ? Otherwise lgtm
danieldk
previously approved these changes
Nov 19, 2025
danieldk
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix build errors like the one below because it is checking for
#if defined(_WIN32) && (defined(USE_CUDA) || defined(USE_ROCM))butUSE_CUDAwas not actually being set for various reasons.