This repository was archived by the owner on Jan 27, 2026. It is now read-only.
Conversation
Before this change, we wouldn't overlay Torch in the package set. The main reason was that evaluation was too expensive -- even more so when we also had C++98 and C++11 variants (which doubled the number of Torch versions). However, this does not really work well with dependencies (some dependencies like `einops` will rely on Torch) or extra test dependencies that a user adds to a flake. So overlay Torch so that all of nixpkgs sees the version that is defined in the build set. In this change, the `cxx11Abi` is also removed and the C++11 ABI is set as the default. Upstream does not build for the C++98 ABI anymore, so it is time to remove the support before it bitrots.
MekkCyber
approved these changes
Dec 10, 2025
Contributor
MekkCyber
left a comment
MekkCyber
left a comment
There was a problem hiding this comment.
Thanks for the quick fix
Member
Author
Helps me with the dependency stuff as well 😄. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, we wouldn't overlay Torch in the package set. The main reason was that evaluation was too expensive -- even more so when we also had C++98 and C++11 variants (which doubled the number of Torch versions).
However, this does not really work well with dependencies (some dependencies like
einopswill rely on Torch) or extra test dependencies that a user adds to a flake. So overlay Torch so that all of nixpkgs sees the version that is defined in the build set.In this change, the
cxx11Abiis also removed and the C++11 ABI is set as the default. Upstream does not build for the C++98 ABI anymore, so it is time to remove the support before it bitrots.