This repository was archived by the owner on Jan 27, 2026. It is now read-only.
build2cmake: fix C++ dependency lookup warnings#326
Merged
Conversation
The C++ dependency lookup in build2cmake would iterate over all kernels, looking up their dependencies. However, this lead to spurious warnings such as: Warning: CUDA backend doesn't need/support dependency: CutlassSycl Fix this by only collecting and then looking up the dependencies of the currently-active backend.
danieldk
force-pushed
the
only-check-backend-deps
branch
from
31203df to
04e9d04
Compare
MekkCyber
approved these changes
Dec 16, 2025
Contributor
MekkCyber
left a comment
MekkCyber
left a comment
There was a problem hiding this comment.
Thanks for fixing this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C++ dependency lookup in build2cmake would iterate over all kernels, looking up their dependencies. However, this lead to spurious warnings such as:
Warning: CUDA backend doesn't need/support dependency: CutlassSycl
Fix this by only collecting and then looking up the dependencies of the currently-active backend.