Skip to content
This repository was archived by the owner on Jan 27, 2026. It is now read-only.

Let build2cmake generate metadata.json#328

Merged
danieldk merged 4 commits intomainfrom
build2cmake-dep-metadata
Dec 17, 2025
Merged

Let build2cmake generate metadata.json#328
danieldk merged 4 commits intomainfrom
build2cmake-dep-metadata

Conversation

@danieldk
Copy link
Member

We were generating it from Nix first, but then we need the same logic on the Windows side. So, instead, let build2cmake generate file and let the Nix/Windows builders put it in place.

@danieldk danieldk force-pushed the build2cmake-dep-metadata branch from eb0b277 to 884ff6a Compare December 16, 2025 11:20
@mfuntowicz mfuntowicz self-requested a review December 17, 2025 09:47
Copy link
Member

@mfuntowicz mfuntowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making it available for Windows too.

Is there already an example kernel leveraging this somewhere I can give it a quick try on a Windows machine?

@danieldk
Copy link
Member Author

Is there already an example kernel leveraging this somewhere I can give it a quick try on a Windows machine?

I think this would be very useful to test with https://github.com/huggingface/kernels-community/tree/main/rmsnorm with this added to build.toml:

[general.xpu]
python-depends = ["onednn"]

@danieldk danieldk merged commit 0253b68 into main Dec 17, 2025
29 checks passed
@danieldk danieldk deleted the build2cmake-dep-metadata branch December 17, 2025 10:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants