use 'native-tls' instead of rustls for reqwest#38
Conversation
|
Is what you're looking to achieve not possible with |
|
Before reading anything here just know I am a rust noob. I am just curious.
I think it is possible with I was just coming around to this for I saw that this repo is the one related to this issue here in llm-vscode. I think after reading this could instead be usage of rustls-native-certs instead of using Reading through the reqwests docs here tells me that the usage of native-tls will probs give us the best by platform import of tls certs trusted by the os. However, what is the reasoning behind using TLDR: I think this MR is just to support using tls certs trusted by the host os, and I wonder if the reason they want to use |
|
Responding to myself here, I realized that you said in the #36 (comment) that you had issues with compiling using openssl. So I think it would be more reasonable to switch to the usage of rustls-native-certs instead which exposes |
|
Closing in favor of #77 |
This aims to solve #36.
Instead of using 'rustls-tls' feature of reqwest, this uses 'native-tls'. This checks the certificates trusted by the operating system, which allows the user to easily trust custom self-signed certificates.
This built fine for me locally on Windows. Let's hope that the CI can build this successfully for all platforms.
Note: I also tried the feature 'rustls-tls-native-roots' which should theoretically also take certificates trusted by the OS into consideration, but I could not get it to trust my certificate.