Merged
Conversation
The CLI already loads direct Anthropic defaults from configs/cli_agent_config.json, but the startup banner was rendered before that config was loaded and fell back to a hardcoded Bedrock label. This made the CLI look misconfigured even when the session model was correct. Constraint: The startup banner must reflect the same model source the CLI session will actually use Rejected: Keep a hardcoded Bedrock fallback in print_banner | it misreports the active CLI default Confidence: high Scope-risk: narrow Reversibility: clean Directive: Banner/status UI should derive model labels from loaded config or session state, never from stale hardcoded defaults Tested: python -m compileall agent/main.py agent/utils/terminal_display.py Not-tested: Interactive manual CLI launch in this sandbox
|
Claude finished @akseljoonas's task in 57s —— View job PR Review: Fix CLI banner model label
LGTM What I checked
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
print_banner()Testing
python -m compileall agent/main.py agent/utils/terminal_display.py