Closed
Conversation
The CLI already reads direct Anthropic defaults from configs/cli_agent_config.json, but the banner was rendered before that config was loaded and fell back to a hardcoded Bedrock label. This made startup output claim the CLI default was Bedrock even when the session was actually using direct Anthropic. Constraint: Startup UI must reflect the same model source the CLI session actually uses Rejected: Keep the hardcoded Bedrock fallback in print_banner | it misreports the active CLI default Confidence: high Scope-risk: narrow Reversibility: clean Directive: Model labels shown in CLI startup/status UI should come from loaded config or live session state, not stale hardcoded defaults Tested: python -m compileall agent/main.py agent/utils/terminal_display.py Not-tested: Interactive manual CLI launch in this sandbox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
print_banner()Why
The CLI session already uses
configs/cli_agent_config.json, but the startup banner still claimed the default model was Bedrock because it was printed before config load.Testing
python -m compileall agent/main.py agent/utils/terminal_display.py