fix(utils): use default_factory for mutable dataclass fields#2440
Open
Leetfs wants to merge 1 commit into
Open
fix(utils): use default_factory for mutable dataclass fields#2440Leetfs wants to merge 1 commit into
Leetfs wants to merge 1 commit into
Conversation
In modern Python versions, using a mutable object (like a class instance) as a default value in a dataclass without `default_factory` raises a ValueError. This strict check prevents unintended shared state across instances (ghost bugs). This commit updates `_RunDefaults.time_benchmark_args` in `optimum.utils.runs` to use `default_factory=BenchmarkTimeArgs` instead of `default=BenchmarkTimeArgs()`. This perfectly resolves the ValueError during module initialization and testing. Signed-off-by: Li Guan <guanli.oerv@isrc.iscas.ac.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a
ValueErrorthat occurs during module initialization in modern Python versions due to the use of a mutable default value in adataclass.Before submitting
Who can review?
@michaelbenayoun @IlyasMoutawwakil