fix(resources): reserve all built-in slash-command prompt names#468
Open
yoshibase wants to merge 1 commit into
Open
fix(resources): reserve all built-in slash-command prompt names#468yoshibase wants to merge 1 commit into
yoshibase wants to merge 1 commit into
Conversation
Derive reserved prompt-template stems from create_default_command_registry() so built-in commands and aliases like /new and /exit cannot be shadowed by markdown templates. Colliding files are ignored with a resource diagnostic instead of silently changing command behavior. Fixes huggingface#460
yoshibase
force-pushed
the
fix/issue-460-reserve-builtin-prompt-names
branch
from
July 24, 2026 16:17
8f83522 to
d8e2dfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_default_command_registry()so every built-in slash command name and alias (e.g.new,quit,exit) cannot shadow real commands via*.mdtemplates/newor/quitbehaviorwebsite/content/guides/skills-and-prompts.mdand add a dev note for validationFixes #460
Test plan
uv run pytest tests/test_prompt_templates.py tests/test_commands.py tests/test_coding_session.pyuv run ruff check .uv run ruff format --check .new.md,quit.md,exit.md, and/reloadconsistency