Remove TrainingArguments import from experimental trainers#5290
Open
albertvillanova wants to merge 1 commit intohuggingface:mainfrom
Open
Remove TrainingArguments import from experimental trainers#5290albertvillanova wants to merge 1 commit intohuggingface:mainfrom
albertvillanova wants to merge 1 commit intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove TrainingArguments import from experimental trainers.
This PR refactors multiple experimental trainer configuration files to remove direct dependencies on
transformers.TrainingArgumentsand instead rely on the project's own_BaseConfigfor managing valid dictionary fields. This change improves modularity and reduces external coupling across the configuration classes.Follow-up to:
Changes
Dependency and configuration updates:
TrainingArgumentsfrom all experimental config files (BCOConfig,CPOConfig,KTOConfig,OnlineDPOConfig,ORPOConfig) to eliminate unnecessary dependency._VALID_DICT_FIELDSin each config class to use_BaseConfig._VALID_DICT_FIELDSinstead ofTrainingArguments._VALID_DICT_FIELDS, ensuring consistency and reducing external dependency.Note
Low Risk
Low risk refactor that only changes how experimental configs derive
_VALID_DICT_FIELDS; runtime impact should be limited to argument/dict field validation if_BaseConfig._VALID_DICT_FIELDSdiffers fromTrainingArgumentsin a given transformers version.Overview
Removes the
TrainingArgumentsimport from several experimental trainer config modules (BCOConfig,CPOConfig,KTOConfig,OnlineDPOConfig,ORPOConfig).Each config now sets
_VALID_DICT_FIELDSbased on_BaseConfig._VALID_DICT_FIELDS(plusmodel_init_kwargs) rather thanTrainingArguments._VALID_DICT_FIELDS, reducing direct coupling totransformersin these experimental configs.Written by Cursor Bugbot for commit c2e93cc. This will update automatically on new commits. Configure here.