Remove firstRowIsWhiteSpace - unused and breaks empty lines#95
Open
zolrath wants to merge 1 commit intohuibizhang:masterfrom
Open
Remove firstRowIsWhiteSpace - unused and breaks empty lines#95zolrath wants to merge 1 commit intohuibizhang:masterfrom
firstRowIsWhiteSpace - unused and breaks empty lines#95zolrath wants to merge 1 commit intohuibizhang:masterfrom
Conversation
The result of this value isn't used but it often fails when clicking on empty lines, resulting in gaps of highlighted text when there are new lines present. Removing this line fixes this issue and removes an unused variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The result of this value isn't used but it often fails when clicking on empty lines, resulting in gaps of highlighted text when there are new lines present.
Removing this line fixes this issue and removes an unused variable.
These pictures show the result of all three of these pull requests, allowing for linear-gradients, fixing the issue with the white line number, and allowing blank lines to be selected.
Before
After