Prevent double save dialog boxes by throttling save click#96
Open
zolrath wants to merge 1 commit intohuibizhang:masterfrom
Open
Prevent double save dialog boxes by throttling save click#96zolrath wants to merge 1 commit intohuibizhang:masterfrom
zolrath wants to merge 1 commit intohuibizhang:masterfrom
Conversation
As it takes about half a second for the save dialog box to appear, its easy to click the save button twice and have a second save dialog box appear after you save the image. Throttle the save button to only be pressed once a second to prevent this from happening.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it takes about half a second for the save dialog box to appear on the first click (it happens more quickly on subsequent clicks). It's easy to click the save button twice and have a second save dialog box appear after you save the image.
This allows the first click through, and then discards further clicks for one second to prevent this from happening.
This doesn't slow any normal usage down since we allow the first click through with no delay but prevents annoyances.