Open
Conversation
The result of this value isn't used but it often fails when clicking on empty lines, resulting in gaps of highlighted text when there are new lines present. Removing this line fixes this issue and removes an unused variable.
It's quite easy to select the end of a line with no text, or an empty line at the start/end of the code you intend to screenshot. This trims the resulting HTML of any blank lines at the start/end of the code, removing the need to reselect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's quite easy to select the end of a line with no text, or an empty line at the start/end of the code you intend to screenshot.
This trims the resulting HTML of any blank lines at the start/end of the code, removing the need to reselect.
With this selection:
Old behavior:
New Behavior: