Pull request: Modifies event-listener setup. Adds additional options.#5
Open
chunksnbits wants to merge 19 commits intohulufei:masterfrom
Open
Pull request: Modifies event-listener setup. Adds additional options.#5chunksnbits wants to merge 19 commits intohulufei:masterfrom
chunksnbits wants to merge 19 commits intohulufei:masterfrom
Conversation
…d class-identifiers for draggable and placeholder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I loved the mixin but since I had a couple of issues getting the mixin to work with dynamic concent, so I made a couple of changes on a fork. Maybe this is also something that is interesting for you (note: my fork was initially based on: https://github.com/ganeshp0001/react-sortable-mixin). The following changes were made:
I have one issue, I am currently not happy with. Maybe you have an idea how to solve this better:
Have a look and if you are interested or require additional changes, feel free to contact me.
Greetings,
Daniel