Build releases before tagging so tags are immutable#22
Merged
Conversation
The release workflow previously created the tag (via the GitHub release UI) and then force-pushed a rewritten tag to stamp the version and add built assets. Packagist requires tags to be immutable and rejected the update. Rework the Release workflow to build and stamp the version BEFORE the tag exists, then create the vX.Y.Z tag once at the built+versioned commit and push it without force. Generate the ZIP with git archive so .gitattributes is the single source of truth for release contents.
Collaborator
Author
|
Go fable :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow previously created the tag (via the GitHub release UI)
and then force-pushed a rewritten tag to stamp the version and add built
assets. Packagist requires tags to be immutable and rejected the update.
Rework the Release workflow to build and stamp the version BEFORE the tag
exists, then create the vX.Y.Z tag once at the built+versioned commit and
push it without force. Generate the ZIP with git archive so .gitattributes
is the single source of truth for release contents.
Supercedes #21