Skip to content

ROS 2 twist mux controller#14

Merged
rafal-gorecki merged 15 commits into
jazzyfrom
ros2-velocity-input-controller
Aug 6, 2025
Merged

ROS 2 twist mux controller#14
rafal-gorecki merged 15 commits into
jazzyfrom
ros2-velocity-input-controller

Conversation

@KmakD

@KmakD KmakD commented Aug 5, 2025

Copy link
Copy Markdown

This add twist mux controller - a chainable controller designed to process velocity commands from multiple sources and forward them to hardware interfaces or other chainable controllers.

There is also low pass filter, also chainable controller, that allows to apply a low-pass filter to state interfaces.

This changes were designed to be used with heading correction, but as twist mux became even more important it should be finally merged to main. The low pass filter is not that important rn, but as it is already implemented there is no point in keeping it on separate branch.

@KmakD KmakD requested a review from rafal-gorecki August 5, 2025 09:50

@rafal-gorecki rafal-gorecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't read the scope of work before and I'm wondering what you think the added value is. I suggest writing your own package instead of using the ready-made twist_mux package?

Comment thread low_pass_filter/package.xml
Comment thread low_pass_filter/README.md
Comment thread low_pass_filter/include/low_pass_filter/low_pass_filter.hpp Outdated
Comment thread low_pass_filter/low_pass_filter_plugin.xml Outdated
Comment thread twist_mux_controller/package.xml
Comment thread twist_mux_controller/include/twist_mux_controller/twist_msg_subscriber.hpp Outdated
Comment thread twist_mux_controller/src/twist_mux_controller.cpp
Comment thread twist_mux_controller/src/twist_mux_controller.cpp
Comment thread twist_mux_controller/src/twist_mux_controller.cpp
@KmakD KmakD requested a review from rafal-gorecki August 6, 2025 11:50
@rafal-gorecki rafal-gorecki merged commit f4f78b7 into jazzy Aug 6, 2025
1 check passed
@rafal-gorecki rafal-gorecki deleted the ros2-velocity-input-controller branch August 6, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants