Support: add per-example case config and trimmed mean to benchmark_rounds#319
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces significant improvements to the benchmark script, including per-example case configuration, a new trimmed mean statistic, and a major refactoring that extracts logic into a run_bench function. These changes enhance the script's flexibility and maintainability. The implementation is solid, and I have one suggestion to simplify a conditional statement for better readability.
0e4fd92 to
7413db7
Compare
…unds - Replace flat EXAMPLES array with declare -A EXAMPLE_CASES map pairing each example with comma-separated case names; empty = run DEFAULT_CASE - Add EXAMPLE_ORDER array to control execution order - Add trimmed mean statistic (excluding min/max) alongside existing avg - Extract run+parse logic into run_bench() with trap-based temp cleanup - Simplify empty case_list check by testing string directly - Unify alternating_matmul_add case names to PascalCase (Case1, Case2)
7413db7 to
6daea51
Compare
Summary
EXAMPLESarray withdeclare -A EXAMPLE_CASESmap pairing each example with comma-separated case names; empty value = runDEFAULT_CASEEXAMPLE_ORDERarray to control benchmark execution orderrun_bench()function with trap-based temp file cleanupalternating_matmul_addcase names to PascalCase (Case1,Case2)Test plan
./tools/benchmark_rounds.shwithout changes — verify default behavior unchangedEXAMPLE_CASESto add cases — verify per-case output with---- CaseX ----headers