Update: unify paged attention golden cases across three test variants#322
Conversation
- paged_attention Case2 batch 256→64, remove Case4/5/6 - paged_attention_unroll Case2 batch 256→64 - All three tests (batch_paged_attention, paged_attention, paged_attention_unroll) now share identical Case1/2/3 configs
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request standardizes the golden test configurations across different paged attention implementations. By unifying the test cases for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request unifies the golden test cases for paged_attention and paged_attention_unroll to match batch_paged_attention. The changes involve updating the batch size for Case2 and removing obsolete test cases (Case4, Case5, Case6) in paged_attention/golden.py, and updating the batch size for Case2 in paged_attention_unroll/golden.py. These modifications successfully align the test configurations as described, improving consistency across the test suite. The changes are straightforward and appear correct.
Summary
All three PA test variants (
batch_paged_attention,paged_attention,paged_attention_unroll) now share identical Case1/2/3 configurations:Test plan
batch_paged_attentiondevice test with all 3 casespaged_attentiondevice test with all 3 casespaged_attention_unrolldevice test with all 3 cases