Update: replace block core assignment with round-robin in AICPU executors#323
Conversation
…tors - host_build_graph: remove even-distribution requirement; assign AIC/AIV cores to threads via round-robin (core i → thread i % thread_num_). thread_cores_num_ becomes a per-thread array so each thread knows its exact core count; aic_per_thread_/aiv_per_thread_ store ceil values used as local queue caps. - tensormap_and_ringbuffer: replace sequential cluster block allocation with round-robin (cluster ci → sched thread ci % divisor). Per-thread core_idx array tracks fill position during assignment; thread_cores_num_ set from ceil(cluster_count/divisor)*3. Both runtimes previously failed when core counts were not evenly divisible by the thread count. Round-robin handles uneven distributions correctly.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the robustness of AICPU core assignment by transitioning from a strict block-based distribution to a flexible round-robin approach. This change addresses previous limitations where core counts had to be evenly divisible by the number of threads, preventing failures in uneven distribution scenarios. The update ensures that both Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively replaces the block-based core assignment with a round-robin strategy in both host_build_graph and tensormap_and_ringbuffer AICPU executors. This change correctly addresses the issue of uneven core distribution among threads. The implementation is sound, with corresponding updates to data structures and logic to support the new assignment method. I have one suggestion to improve code maintainability by reducing duplication in a logging section.
Both runtimes previously failed when core counts were not evenly divisible by the thread count. Round-robin handles uneven distributions correctly.