fix: copy should not include UI line wrapping#80
Open
hyldmo wants to merge 1 commit into
Open
Conversation
getText() currently returns text with visual line breaks from terminal wrapping baked in. These tests document the expected behavior: copy should return original unwrapped text. Blocked on upstream fix: remorses/ghostty-opentui#13 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.todotests documenting thatgetText()should return unwrapped text (original line breaks only, not visual wrapping)getText()returns text with soft-wrap newlines baked in — e.g. a 120-char line in a 40-col terminal comes back as 3 linesRoot cause
ghostty-opentui's nativegetTerminalText()uses the formatter withoutunwrap: true, so it inserts\nat every visual row boundary including soft wraps. This affects both:getText()getSelectedText()which operates on the same wrapped text bufferUpstream fix
PR submitted: remorses/ghostty-opentui#13
Once merged and released, bumping
ghostty-opentuiwill make the.todotests pass.Test plan
bun test src/ui/pane.test.ts— 11 pass, 2 todo, 0 fail🤖 Generated with Claude Code