Restore _write and _flush in WriteLogger.__setstate__#787
Open
bysiber wants to merge 1 commit intohynek:mainfrom
Open
Restore _write and _flush in WriteLogger.__setstate__#787bysiber wants to merge 1 commit intohynek:mainfrom
bysiber wants to merge 1 commit intohynek:mainfrom
Conversation
After unpickling a WriteLogger, calling any log method (msg, info, debug, etc.) raises AttributeError because __setstate__ only restores _file and _lock but not _write and _flush. BytesLogger.__setstate__ already handles this correctly, and so does WriteLogger.__deepcopy__ — this was just an oversight in __setstate__.
|
@hynek heads up , this one has been running a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WriteLogger.__setstate__restores_fileand_lockbut not_writeand_flush. After unpickling, any log method raisesAttributeError:BytesLogger.__setstate__already restores all four attributes correctly, andWriteLogger.__deepcopy__does too — this was just missed in__setstate__.The fix adds the two missing assignments after restoring
_file.