Harden extension/session key display normalization

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/extension_utils.py

@@ -15,21 +15,24 @@ def _get_type_name(value: Any) -> str:
 
 def _safe_stringify_key(value: object) -> str:
     try:
-        return str(value)
+        normalized_key = str(value)
+        if type(normalized_key) is not str:
+            raise TypeError("normalized key must be a string")
+        return normalized_key
     except Exception:
         return f"<unprintable {_get_type_name(value)}>"
 
 
 def _format_key_display(value: object) -> str:
     try:
         normalized_key = _safe_stringify_key(value)
-        if not isinstance(normalized_key, str):
+        if type(normalized_key) is not str:
             raise TypeError("normalized key display must be a string")
         normalized_key = "".join(
             "?" if ord(character) < 32 or ord(character) == 127 else character
             for character in normalized_key
         ).strip()
-        if not isinstance(normalized_key, str):
+        if type(normalized_key) is not str:
             raise TypeError("normalized key display must be a string")
     except Exception:
         return "<unreadable key>"

hyperbrowser/client/managers/session_utils.py

@@ -16,7 +16,7 @@ def _format_recording_key_display(key: str) -> str:
             "?" if ord(character) < 32 or ord(character) == 127 else character
             for character in key
         ).strip()
-        if not isinstance(normalized_key, str):
+        if type(normalized_key) is not str:
             raise TypeError("normalized recording key display must be a string")
     except Exception:
         return "<unreadable key>"

tests/test_extension_utils.py

@@ -178,6 +178,24 @@ def __str__(self) -> str:
         parse_extension_list_response_data({_BrokenStringKey(): "value"})
 
 
+def test_parse_extension_list_response_data_missing_key_handles_string_subclass_str_results():
+    class _StringSubclassKey:
+        class _RenderedKey(str):
+            pass
+
+        def __str__(self) -> str:
+            return self._RenderedKey("subclass-key")
+
+    with pytest.raises(
+        HyperbrowserError,
+        match=(
+            "Expected 'extensions' key in response but got "
+            "\\[<unprintable _StringSubclassKey>\\] keys"
+        ),
+    ):
+        parse_extension_list_response_data({_StringSubclassKey(): "value"})
+
+
 def test_parse_extension_list_response_data_missing_key_handles_unreadable_keys():
     class _BrokenKeysMapping(dict):
         def keys(self):
@@ -371,7 +389,7 @@ def __getitem__(self, key: str) -> object:
 
     with pytest.raises(
         HyperbrowserError,
-        match="Failed to read extension object value for key '<unreadable key>' at index 0",
+        match="Failed to read extension object value for key '<unprintable _BrokenKey>' at index 0",
     ) as exc_info:
         parse_extension_list_response_data(
             {"extensions": [_BrokenValueLookupMapping()]}