feat: Make server ping response data a resource#948
Merged
TestingPlant merged 2 commits intohyperion-mc:mainfrom Oct 6, 2025
Merged
feat: Make server ping response data a resource#948TestingPlant merged 2 commits intohyperion-mc:mainfrom
TestingPlant merged 2 commits intohyperion-mc:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors hardcoded server ping response data into a configurable Bevy resource, making the server description and max player count customizable through the ServerPingResponse resource instead of being embedded directly in the code.
- Introduces
ServerPingResponsestruct as a Bevy resource to hold server ping data - Replaces hardcoded values in the status request handler with resource data
- Registers the new resource in the plugin initialization
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1786e56 to
a40fcbe
Compare
TestingPlant
reviewed
Oct 2, 2025
Co-authored-by: TestingPlant <44930139+TestingPlant@users.noreply.github.com>
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #948 +/- ##
==========================================
+ Coverage 23.22% 23.28% +0.05%
==========================================
Files 157 157
Lines 15494 15505 +11
Branches 486 486
==========================================
+ Hits 3599 3610 +11
Misses 11794 11794
Partials 101 101
🚀 New features to boost your workflow:
|
TestingPlant
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤷♂️