Recipes for commonvoice ASR and LID#129
Recipes for commonvoice ASR and LID#129neillu23 wants to merge 116 commits intohyperion-ml:persephone-asrfrom
Conversation
Persephone asr
jesus-villalba
left a comment
There was a problem hiding this comment.
If you haven't, could you pass black on the python files you changed? you can config vscode to do it automatically each time you save, otherwise you can just run "black file_path" on each file.
| t2 = time.time() | ||
|
|
||
| if output_sampling_rate is not None: | ||
| x = signal.resample(x, int(x.shape[0]*output_sampling_rate/fs)) |
There was a problem hiding this comment.
signal resample may not be a good option, I don't know if it could affect audio quality. I used this function for the VAD because I just wanted to stretch it from frame-level to sample level vad. But I don't know if this function is good for audio. Could you check the audios you got?
| @@ -0,0 +1,261 @@ | |||
| #!/usr/bin/env python | |||
| """ | |||
There was a problem hiding this comment.
has this faile something different to wav2vec2xvector trainer?
| else: | ||
| assert "duration" in self.seg_set | ||
|
|
||
|
|
There was a problem hiding this comment.
run black on this file and other files python file you edited to remove the extra white lines
| parser.add_argument( | ||
| "--base-sampler-type", | ||
| choices=["seg_sampler", "bucketing_seg_sampler"], | ||
| choices=["seg_sampler", "bucketing_seg_sampler", "bucketing_seg_sampler","class_weighted_seg_sampler"], |
There was a problem hiding this comment.
there is a repeated choice
| from .vae.vae import VAE | ||
| from .vae.vq_vae import VQVAE | ||
| from .transducer import RNNTransducer, RNNRNNTransducer | ||
| from .wav2languageid import HFWav2Vec2ResNet1dLanguageID |
There was a problem hiding this comment.
Do we need this one?
| x: torch.Tensor, | ||
| x_lengths: torch.Tensor, | ||
| y: k2.RaggedTensor, | ||
| y: Union[Dict, k2.RaggedTensor], |
| @@ -0,0 +1,7 @@ | |||
| """ | |||
There was a problem hiding this comment.
can we delete this directory?
| @@ -0,0 +1,7 @@ | |||
| """ | |||
There was a problem hiding this comment.
I would invert the name to languageid_transducer since we do first the language id and the we want to use it for the asr
| @@ -0,0 +1,212 @@ | |||
| """ | |||
There was a problem hiding this comment.
can we delete this one?
…erion into persephone-refactor
No description provided.