Implement perfect addition of two SizeHint's#156
Merged
seanmonstar merged 3 commits intohyperium:masterfrom Jul 29, 2025
Merged
Implement perfect addition of two SizeHint's#156seanmonstar merged 3 commits intohyperium:masterfrom
SizeHint's#156seanmonstar merged 3 commits intohyperium:masterfrom
Conversation
cratelyn
approved these changes
Jul 29, 2025
Member
cratelyn
left a comment
cratelyn
left a comment
There was a problem hiding this comment.
thank you for opening this @ultrabear!
i support this change. i have implemented similar logic myself, and the ability to add hints together seems like a reasonable decision to me as well.
seanmonstar
requested changes
Jul 29, 2025
Member
seanmonstar
left a comment
seanmonstar
left a comment
There was a problem hiding this comment.
Seems reasonable to me! Since it's juggling some options and addition, what if we include some tests, the both LHS and RHS with/without an upper add correctly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was useful to implement for a DoubleBody implementation, it's low complexity and seemingly only has one logical implementation so I made a quick PR for it