Derive Copy trait to SizeHint struct#164
Merged
seanmonstar merged 1 commit intohyperium:masterfrom Nov 25, 2025
Merged
Conversation
cratelyn
approved these changes
Nov 20, 2025
Member
cratelyn
left a comment
cratelyn
left a comment
There was a problem hiding this comment.
thank you, @cgzones.
i confirmed that this size is smaller than some types marked Copy in the standard library, to convince myself that this is a reasonable change.
before this can merge, however, there are some clippy lints that we'll need to address. now that this is marked as a Copy type, we'll want to make a pass through the code here and remove any .clone() calls.
once that's done, i'd be in support of this merging! 👍
The struct has only a size of 24 bytes and is trivially copy-able.
Member
|
this looks good, i'd just like @seanmonstar to take a look before this is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The struct has only a size of 24 bytes and is trivially copy-able.