Implement Read/Write for Pin<P>#3413
Merged
seanmonstar merged 1 commit intohyperium:masterfrom Nov 16, 2023
Merged
Conversation
Without these impls, something like Pin<Box<T: Read>> does not actually implement Read. Closes hyperium#3412 BREAKING CHANGE: Pin is #[fundamental], so this theoretically conflicts with existing user Read/Write for Pin<...> impls. However, those impls probably don't exist yet.
seanmonstar
reviewed
Nov 15, 2023
seanmonstar
approved these changes
Nov 16, 2023
Contributor
Author
|
Oh, woah, wild, I was looking in the Rust changelog for something totally unrelated to this and found rust-lang/rust#81363, which shows it was sorta an under-specification of Pin at the time. |
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this pull request
Jan 12, 2024
Without these impls, something like Pin<Box<T: Read>> does not actually implement Read. Closes hyperium#3412 BREAKING CHANGE: Pin is #[fundamental], so this theoretically conflicts with existing user Read/Write for Pin<...> impls. However, those impls probably don't exist yet.
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this pull request
Jan 16, 2024
Without these impls, something like Pin<Box<T: Read>> does not actually implement Read. Closes hyperium#3412 BREAKING CHANGE: Pin is #[fundamental], so this theoretically conflicts with existing user Read/Write for Pin<...> impls. However, those impls probably don't exist yet. Signed-off-by: Sven Pfennig <s.pfennig@reply.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3412