Skip to content

feat(hover): add missing descriptions for older json schema drafts#266

Open
adityayadav-dev wants to merge 1 commit intohyperjump-io:mainfrom
adityayadav-dev:main
Open

feat(hover): add missing descriptions for older json schema drafts#266
adityayadav-dev wants to merge 1 commit intohyperjump-io:mainfrom
adityayadav-dev:main

Conversation

@adityayadav-dev
Copy link
Copy Markdown

Summary

Adds missing hover tooltip descriptions for several keywords in draft-04, draft-06, and draft-07 that were previously left blank or missing. Also uncomments the corresponding test assertions that were marked as TODO.

Closes #256

Changes

language-server/src/features/hover.js

draft-04 — filled in empty descriptions for:

  • id — identifier for the schema resource
  • dependencies — rules evaluated when an object contains a certain property
  • exclusiveMaximum — strict less-than validation (boolean form in draft-04)
  • exclusiveMinimum — strict greater-than validation (boolean form in draft-04)
  • maximum — less-than-or-equal validation
  • minimum — greater-than-or-equal validation

draft-06 — added new entries for:

  • $id — identifier for the schema resource
  • dependencies — rules evaluated when an object contains a certain property

draft-07 — added new entries for:

  • $id — identifier for the schema resource
  • dependencies — rules evaluated when an object contains a certain property

language-server/src/features/hover.test.ts

Uncommented all TODO test assertions so the previously skipped keywords are now regression-tested:

  • draft-07: $id, dependencies
  • draft-06: $id, dependencies
  • draft-04: id, maximum, exclusiveMaximum, minimum, exclusiveMinimum, dependencies

Testing

All 5768 tests pass (24 test files), including the newly enabled hover assertions for all three drafts.

@adityayadav-dev
Copy link
Copy Markdown
Author

Hey @jdesrosiers , I have made the changes. Please take a look when you have time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Missing Hover Descriptions for Older JSON Schema Drafts

1 participant