add method for checking eip1559 support#197
Merged
Merged
Conversation
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
… eip1559 Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
peterbroadhurst
approved these changes
Jul 8, 2026
peterbroadhurst
left a comment
peterbroadhurst
left a comment
Contributor
There was a problem hiding this comment.
👍 - looks clear and straight forward.
The BlockInfoJSONRPC doesn't contain the transactions, so the extra memory is trivial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a method for consumers to get the block info of the highest block. So that it can be used to check whether EIP1559 is supported using the presence of "baseFeePerGas" field from the block header.
Note: instead of introducing a
GetBlockBaseFeePerGasorSupportsEIP1559in the BlockListener interface. I decided to cache and return the entire block info. So if other fields in the block info need to be used for other checks, we don't need to keep adding separate functions for them at the block listener interface.