Skip to content

Ensure it is possible to correlate the request and response logs for webhooks#1740

Merged
EnriqueL8 merged 2 commits into
hyperledger-firefly:mainfrom
davecrighton:djc/webhookLogContext
Jul 6, 2026
Merged

Ensure it is possible to correlate the request and response logs for webhooks#1740
EnriqueL8 merged 2 commits into
hyperledger-firefly:mainfrom
davecrighton:djc/webhookLogContext

Conversation

@davecrighton

Copy link
Copy Markdown
Contributor

Proposed changes

Currently the logs for webhook requests do not carry the bReq correlator on the response. The issue is that the wrong context is passed into the log call that logs the response.

Types of changes

  • Bug fix
  • New feature added
  • Documentation Update

Please make sure to follow these points

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes have sufficient code coverage (unit, integration, e2e tests).

Screenshots (If Applicable)

n/a


Other Information

Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc.

@davecrighton davecrighton requested a review from a team as a code owner July 2, 2026 10:57
…webhooks

Signed-off-by: Dave Crighton <dave.crighton@kaleido.io>
@davecrighton davecrighton force-pushed the djc/webhookLogContext branch from aa58921 to 9ea8490 Compare July 2, 2026 15:43

@EnriqueL8 EnriqueL8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davecrighton !

@EnriqueL8 EnriqueL8 merged commit 9d0ed84 into hyperledger-firefly:main Jul 6, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants