Open
Conversation
added 4 commits
December 9, 2025 23:38
Signed-off-by: mineme0110 <shailesh.patil@iohk.io>
Signed-off-by: mineme0110 <shailesh.patil@iohk.io>
Signed-off-by: mineme0110 <shailesh.patil@iohk.io>
Signed-off-by: mineme0110 <shailesh.patil@iohk.io>
Contributor
Contributor
added 2 commits
December 10, 2025 09:29
Signed-off-by: mineme0110 <shailesh.patil@iohk.io>
Signed-off-by: mineme0110 <shailesh.patil@iohk.io>
Signed-off-by: mineme0110 <shailesh.patil@iohk.io>
amagyar-iohk
requested changes
Dec 11, 2025
| run: | | ||
| ./docker/run.sh "$AGENT_VERSION" | ||
| npm i | ||
| npm install |
Contributor
There was a problem hiding this comment.
for pinned version we should use npm ci
Contributor
Author
There was a problem hiding this comment.
I will see what can be done it is bit tricky since no package-lock.json
added 3 commits
December 11, 2025 18:16
Signed-off-by: mineme0110 <shailesh.patil@iohk.io>
Signed-off-by: mineme0110 <shailesh.patil@iohk.io>
Signed-off-by: mineme0110 <shailesh.patil@iohk.io>
|
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summarize the changes you're submitting in a few sentences, including Jira ticket ATL-xxxx if applicable.
Link to any discussion, related issues and bug reports to give the context to help the reviewer understand the PR.
Alternatives Considered (optional)
Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.
Checklist